Re: [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add wol-arp-packet property
From: Conor Dooley <conor@kernel.org>
Date: 2024-01-30 17:30:38
Also in:
linux-devicetree, lkml
On Tue, Jan 30, 2024 at 04:18:44PM +0530, Vineeth Karumanchi wrote:
"wol-arp-packet" property enables WOL with ARP packet. It is an extension to "magic-packet for WOL.
If it is an extension to "magic-packet" why does it not depend on "magic-packet"? Are there systems that would only support the magic arp packet but a regular magic packet?
quoted hunk ↗ jump to hunk
Signed-off-by: Vineeth Karumanchi <redacted> --- 7c4a1d0cfdc1 net: macb: make magic-packet property generic which added magic-property support and wol-arp-packet addition is similar extension. --- Documentation/devicetree/bindings/net/cdns,macb.yaml | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml index bf8894a0257e..4bea177e85bc 100644 --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml@@ -144,6 +144,11 @@ patternProperties: description: Indicates that the hardware supports waking up via magic packet. + wol-arp-packet:
Bikeshedding perhaps, but why not call it "magic-arp-packet" if it has the same function as the other property here? Thanks, Conor.
+ type: boolean
+ description:
+ Indicates that the hardware supports waking up via ARP packet.
+
unevaluatedProperties: false
required:
--
2.34.1Attachments
- signature.asc [application/pgp-signature] 228 bytes