Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
From: Jiri Pirko <jiri@resnulli.us>
Date: 2024-01-30 10:05:34
Also in:
lkml
Tue, Jan 30, 2024 at 10:22:55AM CET, chentao@kylinos.cn wrote:
quoted hunk ↗ jump to hunk
commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation") introduces a new macro. Use the new KMEM_CACHE() macro instead of direct kmem_cache_create to simplify the creation of SLAB caches. Signed-off-by: Kunwu Chan <redacted> --- net/ipv4/inetpeer.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c index e9fed83e9b3c..5bd759963451 100644 --- a/net/ipv4/inetpeer.c +++ b/net/ipv4/inetpeer.c@@ -81,10 +81,7 @@ void __init inet_initpeers(void)inet_peer_threshold = clamp_val(nr_entries, 4096, 65536 + 128); - peer_cachep = kmem_cache_create("inet_peer_cache", - sizeof(struct inet_peer), - 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC, - NULL); + peer_cachep = KMEM_CACHE(inet_peer, SLAB_HWCACHE_ALIGN | SLAB_PANIC);
The name is going to be different. Could it be a source of some issue? My guess is not, just want to make sure.
} /* Called with rcu_read_lock() or base->lock held */ -- 2.39.2