Thread (20 messages) flat view 20 messages, 5 authors, 2024-01-29

RE: [PATCH next 10/11] block: Use a boolean expression instead of max() on booleans

From: David Laight <hidden>
Date: 2024-01-29 09:23:09
Also in: dri-devel, linux-btrfs, lkml

From: Jani Nikula
Sent: 29 January 2024 09:08

On Sun, 28 Jan 2024, David Laight [off-list ref] wrote:
quoted
blk_stack_limits() contains:
	t->zoned = max(t->zoned, b->zoned);
These are bool, so it is just a bitwise or.
Should be a logical or, really. And || in code.
Not really, bitwise is fine for bool (especially for 'or')
and generates better code.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help