Thread (9 messages) flat view 9 messages, 2 authors, 2024-01-19

RE: [PATCH net v5 1/4] dpll: fix broken error path in dpll_pin_alloc(..)

From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
Date: 2024-01-19 13:50:12
Also in: lkml

From: Jiri Pirko <jiri@resnulli.us>
Sent: Thursday, January 18, 2024 12:33 PM

Thu, Jan 18, 2024 at 12:07:16PM CET, arkadiusz.kubalewski@intel.com wrote:
quoted
If pin type is not expected, or dpll_pin_prop_dup(..) failed to
allocate memory, the unwind error path shall not destroy pin's xarrays,
which were not yet initialized.
Add new goto label and use it to fix broken error path.

Fixes: 9431063ad323 ("dpll: core: Add DPLL framework base functions")
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Reviewed-by: Jiri Pirko <redacted>
Thank you!
Arkadiusz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help