Thread (11 messages) 11 messages, 3 authors, 2024-01-05

Re: [net-next PATCH v8 3/5] net: phy: add support for PHY LEDs polarity modes

From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-01-05 02:25:46
Also in: linux-arm-kernel, linux-devicetree, linux-leds, lkml

quoted
quoted
+	 * @dev: PHY device which has the LED
+	 * @index: Which LED of the PHY device or -1
+	 * @modes: bitmap of LED polarity modes
+	 *
+	 * Configure LED with all the required polarity modes in @modes
+	 * to make it correctly turn ON or OFF.
index == -1 should be explained.
If you are referring to the special way of setting the LED globally,
that is not a thing anymore. Rob pointed out that having the double
reference in DT is problematic and PHY driver should handle that
internally.
So it sounds like you need to change
quoted
quoted
+	 * @index: Which LED of the PHY device or -1
to remove the 'or -1'

   Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help