[PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 01/13] net: phy: Introduce ethernet link topology representation · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
Re: [PATCH net-next v5 01/13] net: phy: Introduce ethernet link topology representation · Jakub Kicinski <kuba@kernel.org> · 2024-01-04
Re: [PATCH net-next v5 01/13] net: phy: Introduce ethernet link topology representation · Andrew Lunn <andrew@lunn.ch> · 2024-01-05
Re: [PATCH net-next v5 01/13] net: phy: Introduce ethernet link topology representation · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-05
Re: [PATCH net-next v5 01/13] net: phy: Introduce ethernet link topology representation · Jakub Kicinski <kuba@kernel.org> · 2024-01-05
[PATCH net-next v5 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
Re: [PATCH net-next v5 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY · "Russell King (Oracle)" <linux@armlinux.org.uk> · 2024-01-03
Re: [PATCH net-next v5 02/13] net: sfp: pass the phy_device when disconnecting an sfp module's PHY · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-03
[PATCH net-next v5 03/13] net: phy: add helpers to handle sfp phy connect/disconnect · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 04/13] net: sfp: Add helper to return the SFP bus name · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 05/13] net: ethtool: Allow passing a phy index for some commands · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
Re: [PATCH net-next v5 05/13] net: ethtool: Allow passing a phy index for some commands · Jakub Kicinski <kuba@kernel.org> · 2024-01-04
Re: [PATCH net-next v5 05/13] net: ethtool: Allow passing a phy index for some commands · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-05
[PATCH net-next v5 06/13] netlink: specs: add phy-index as a header parameter · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Jakub Kicinski <kuba@kernel.org> · 2024-01-04
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-05
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Andrew Lunn <andrew@lunn.ch> · 2024-01-05
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-24
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Andrew Lunn <andrew@lunn.ch> · 2024-01-24
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-25
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Andrew Lunn <andrew@lunn.ch> · 2024-01-25
Re: [PATCH net-next v5 07/13] net: ethtool: Introduce a command to list PHYs on an interface · Jakub Kicinski <kuba@kernel.org> · 2024-01-05
[PATCH net-next v5 08/13] netlink: specs: add ethnl PHY_GET command set · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 09/13] net: ethtool: plca: Target the command to the requested PHY · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 10/13] net: ethtool: pse-pd: Target the command to the requested PHY · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 11/13] net: ethtool: cable-test: Target the command to the requested PHY · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 12/13] net: ethtool: strset: Allow querying phy stats by index · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
[PATCH net-next v5 13/13] Documentation: networking: document phy_link_topology · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2023-12-21
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · patchwork-bot+netdevbpf@kernel.org · 2024-01-01
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · "Russell King (Oracle)" <linux@armlinux.org.uk> · 2024-01-02
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · Jakub Kicinski <kuba@kernel.org> · 2024-01-02
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-03
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · Jakub Kicinski <kuba@kernel.org> · 2024-01-04
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · Florian Fainelli <f.fainelli@gmail.com> · 2024-01-04
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · Jakub Kicinski <kuba@kernel.org> · 2024-01-05
Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2024-01-05

Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2024-01-04 23:50:44
Also in: linux-arm-kernel, lkml

On 1/4/24 15:47, Jakub Kicinski wrote:

On Wed, 3 Jan 2024 15:33:36 +0100 Maxime Chevallier wrote:

quoted

I think this could help in reviewing the overall design and identifying
any glaring issue with this.

The netlink handling looks a bit wobbly to me.
I commented best I could in the 20min I had to look at this code :(
I think it'd be best to revert, if you don't mind, because reviewing
incremental fixes will get even harder.

+1
-- 
Florian

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help