Thread (5 messages) flat view 5 messages, 2 authors, 2024-01-02

Re: [PATCH] sunrpc: Improve exception handling in krb5_etm_checksum()

From: Markus Elfring <hidden>
Date: 2024-01-02 09:26:44
Also in: kernel-janitors, linux-nfs, lkml

quoted hunk ↗ jump to hunk
+++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
quoted hunk ↗ jump to hunk
@@ -970,8 +969,7 @@ u32 krb5_etm_checksum(struct crypto_sync_skcipher *cipher,

 out_free_ahash:
 	ahash_request_free(req);
-out_free_mem:
-	kfree(iv);
+out_free_cksumdata:
 	kfree_sensitive(checksumdata);
 	return err ? GSS_S_FAILURE : GSS_S_COMPLETE;
 }
…

How do you think about to use the identifier “out_free_checksumdata”?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help