On 1/31/24 2:30 PM, Jakub Kicinski wrote:

External email: Use caution opening links or attachments


On Wed, 31 Jan 2024 13:41:07 -0800 Jacob Keller wrote:

quoted

quoted

quoted

Still, I feel like shared buffer pools / shared queues is how majority
of drivers implement representors. Did you had a look around?

Yes, I look at Intel ICE driver, which also has representors. (Add to CC)

IIUC, it's still dedicated buffer for each reps, so this new API might help.

Yea, I am pretty sure the ice implementation uses dedicated buffers for
representors right now.

I just did a grep on METADATA_HW_PORT_MUX and assumed bnxt, ice and nfp
all do buffer sharing. You're saying you mux Tx queues but not Rx
queues? Or I need to actually read the code instead of grepping? :)

I guess bnxt, ice, nfp are doing tx buffer sharing?


This devlink sd is for RX queues not TX queues.

And devlink-sd creates a pool of shared descriptors only for RX queue.

The TX queues/ TX path remain unchanged.

William