On 1/24/2024 7:21 AM, Lukasz Plachno wrote:

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


From: Jakub Buchocki <redacted>

Add support for 'flow-type ether' Flow Director rules via ethtool.

Rules not containing masks are processed by the Flow Director,
and support the following set of input parameters in all combinations:
src, dst, proto, vlan-etype, vlan, action.

It is possible to specify address mask in ethtool parameters but only
00:00:00:00:00 and FF:FF:FF:FF:FF are valid.
The same applies to proto, vlan-etype and vlan masks:
only 0x0000 and 0xffff masks are valid.

Signed-off-by: Jakub Buchocki <redacted>
Co-developed-by: Mateusz Pacuszka <redacted>
Signed-off-by: Mateusz Pacuszka <redacted>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Lukasz Plachno <redacted>
---
  .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 140 +++++++++++++++++-
  drivers/net/ethernet/intel/ice/ice_fdir.c     |  27 ++++
  drivers/net/ethernet/intel/ice/ice_fdir.h     |  11 ++
  drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
  4 files changed, 178 insertions(+), 1 deletion(-)

FWIW, Seems okay to me. Thanks for adding the warning prints.

Reviewed-by: Brett Creeley <brett.creeley@amd.com>

[...]