Re: [PATCH net] net: dsa: fix netdev_priv() dereference before check on non-DSA netdevice events
From: Eric Dumazet <edumazet@google.com>
Date: 2024-01-10 13:19:43
On Wed, Jan 10, 2024 at 1:34 AM Vladimir Oltean [off-list ref] wrote:
After the blamed commit, we started doing this dereference for every
NETDEV_CHANGEUPPER and NETDEV_PRECHANGEUPPER event in the system.
static inline struct dsa_port *dsa_user_to_port(const struct net_device *dev)
{
struct dsa_user_priv *p = netdev_priv(dev);
return p->dp;
}Reviewed-by: Eric Dumazet <edumazet@google.com> Thanks for the fix !