On Tue, 9 Jan 2024 08:57:59 -0800 David Wei wrote:

quoted

quoted

+	ret = sscanf(buf, "%u %u", &id, &port);
+	if (ret != 2) {
+		pr_err("Format is peer netdevsim \"id port\" (uint uint)\n");  

netif_err() or dev_err() ? Granted the rest of the file seems to use
pr_err(), but I'm not sure why...  

I can change it to use one of these two in this patchset, then I can
chnage the others separately in another patch. How does that sound?

Separate patch and separate series. Let's not load more unrelated
patches into this series :)