Re: [PATCH net-next 1/1] net: introduce OpenVPN Data Channel Offload (ovpn)
From: kernel test robot <hidden>
Date: 2024-01-07 15:43:29
Also in:
llvm, oe-kbuild-all
Hi Antonio, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Antonio-Quartulli/net-introduce-OpenVPN-Data-Channel-Offload-ovpn/20240107-061631 base: net-next/main patch link: https://lore.kernel.org/r/20240106215740.14770-2-antonio%40openvpn.net patch subject: [PATCH net-next 1/1] net: introduce OpenVPN Data Channel Offload (ovpn) config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20240107/202401072315.mmiDVWdK-lkp@intel.com/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240107/202401072315.mmiDVWdK-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202401072315.mmiDVWdK-lkp@intel.com/ (local) All error/warnings (new ones prefixed by >>):
quoted
drivers/net/ovpn/netlink.c:42:31: error: call to undeclared function 'NLA_POLICY_MAX_LEN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
42 | [OVPN_A_KEYDIR_CIPHER_KEY] = NLA_POLICY_MAX_LEN(U8_MAX),
| ^quoted
drivers/net/ovpn/netlink.c:42:31: warning: suggest braces around initialization of subobject [-Wmissing-braces]
42 | [OVPN_A_KEYDIR_CIPHER_KEY] = NLA_POLICY_MAX_LEN(U8_MAX),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| { }quoted
drivers/net/ovpn/netlink.c:42:31: error: initializer element is not a compile-time constant
42 | [OVPN_A_KEYDIR_CIPHER_KEY] = NLA_POLICY_MAX_LEN(U8_MAX),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ovpn/netlink.c:63:27: warning: suggest braces around initialization of subobject [-Wmissing-braces]
63 | [OVPN_A_PEER_LOCAL_IP] = NLA_POLICY_MAX_LEN(sizeof(struct in6_addr)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| { }
drivers/net/ovpn/netlink.c:64:29: warning: suggest braces around initialization of subobject [-Wmissing-braces]
64 | [OVPN_A_PEER_LOCAL_PORT] = NLA_POLICY_MAX_LEN(sizeof(u16)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| { }
drivers/net/ovpn/netlink.c:63:27: error: initializer element is not a compile-time constant
63 | [OVPN_A_PEER_LOCAL_IP] = NLA_POLICY_MAX_LEN(sizeof(struct in6_addr)),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ovpn/netlink.c:75:20: warning: suggest braces around initialization of subobject [-Wmissing-braces]
75 | [OVPN_A_IFNAME] = NLA_POLICY_MAX_LEN(IFNAMSIZ),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| { }
drivers/net/ovpn/netlink.c:75:20: error: initializer element is not a compile-time constant
75 | [OVPN_A_IFNAME] = NLA_POLICY_MAX_LEN(IFNAMSIZ),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings and 4 errors generated.
--quoted
drivers/net/ovpn/peer.c:366: warning: Function parameter or member 'src' not described in 'ovpn_nexthop_lookup4' drivers/net/ovpn/peer.c:366: warning: expecting prototype for ovpn_rpf4(). Prototype was for ovpn_nexthop_lookup4() instead drivers/net/ovpn/peer.c:412: warning: Function parameter or member 'addr' not described in 'ovpn_nexthop_lookup6' drivers/net/ovpn/peer.c:412: warning: expecting prototype for ovpn_rpf6(). Prototype was for ovpn_nexthop_lookup6() instead
vim +/NLA_POLICY_MAX_LEN +42 drivers/net/ovpn/netlink.c
39
40 /** KEYDIR policy. Can be used for configuring an encryption and a decryption key */
41 static const struct nla_policy ovpn_nl_policy_keydir[NUM_OVPN_A_KEYDIR] = {
> 42 [OVPN_A_KEYDIR_CIPHER_KEY] = NLA_POLICY_MAX_LEN(U8_MAX),
43 [OVPN_A_KEYDIR_NONCE_TAIL] = NLA_POLICY_EXACT_LEN(NONCE_TAIL_SIZE),
44 };
45
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki