Re: [PATCH v3 2/6] x86/vmware: Introduce vmware_hypercall API

From
<hidden>
Date
2023-12-20 00:52:32
Also in
dri-devel, linux-input, lkml, virtualization
Reply to
Alexey Makhalov, 2023-12-20
On Tue, Dec 19, 2023 at 04:17:40PM -0800, Alexey Makhalov wrote:

On 12/19/23 3:20 PM, kirill.shutemov@linux.intel.com wrote:
quoted
On Tue, Dec 19, 2023 at 01:57:47PM -0800, Alexey Makhalov wrote:
quoted
+static inline
+unsigned long vmware_hypercall1(unsigned long cmd, unsigned long in1)
...
quoted
+static inline
+unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1,
+				uint32_t *out1, uint32_t *out2)
...
quoted
+static inline
+unsigned long vmware_hypercall4(unsigned long cmd, unsigned long in1,
+				uint32_t *out1, uint32_t *out2,
+				uint32_t *out3)
...
quoted
+static inline
+unsigned long vmware_hypercall5(unsigned long cmd, unsigned long in1,
+				unsigned long in3, unsigned long in4,
+				unsigned long in5, uint32_t *out2)
...
quoted
+static inline
+unsigned long vmware_hypercall6(unsigned long cmd, unsigned long in1,
+				unsigned long in3, uint32_t *out2,
+				uint32_t *out3, uint32_t *out4,
+				uint32_t *out5)
...
quoted
+static inline
+unsigned long vmware_hypercall7(unsigned long cmd, unsigned long in1,
+				unsigned long in3, unsigned long in4,
+				unsigned long in5, uint32_t *out1,
+				uint32_t *out2, uint32_t *out3)
Naming is weird. The number in the name doesn't help much as there seems
no system on how many of the parameters are ins and outs.
There was internal discussion on hypercall API naming. One of proposals was
using 2 digits - number of input and number of output arguments.
And it definitely looked weird. So, we agreed to have just single number  -
total number of arguments excluding cmd.
Have you considered naming them by number of input parameters? Number of
output parameters as demanded by users.

So vmware_hypercall4() will become vmware_hypercall1() and current
vmware_hypercall1() and vmware_hypercall3() will go away.

It is still awful, but /maybe/ better that this, I donno.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov
Thread (16 messages) 16 messages, 3 authors, last reply 2023-12-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help