RE: [PATCH net-next v6 1/6] ptp: clockmatrix: support 32-bit address space
From: Min Li <hidden>
Date: 2023-12-13 21:04:18
Also in:
lkml
From: Min Li <hidden>
Date: 2023-12-13 21:04:18
Also in:
lkml
My reading is that this patch reverses the usage of module and regaddr. F.e. the following hunk:@@ -553,11 +554,11 @@ static int _sync_pll_output(struct idtcm *idtcm,val = SYNCTRL1_MASTER_SYNC_RST; /* Place master sync in reset */ err = idtcm_write(idtcm, 0, sync_ctrl1, &val, sizeof(val)); err = idtcm_write(idtcm, sync_ctrl1, 0, &val, sizeof(val)); if (err) return err; err = idtcm_write(idtcm, 0, sync_ctrl0, &sync_src, sizeof(sync_src)); err = idtcm_write(idtcm, sync_ctrl0, 0, &sync_src, sizeof(sync_src)); if (err) return err; If that is really intended I think it needs to be explained, or possibly a separate patch.
Hi Simon sync_ctrl0/1 was meant to be a module and it was in a wrong place. And this patch is just correcting it.