On Tue, Dec 12, 2023 at 04:42:45PM +0000, Daniel Golle wrote:

On Tue, Dec 12, 2023 at 04:21:38PM +0000, Conor Dooley wrote:

quoted

On Tue, Dec 12, 2023 at 03:46:26AM +0000, Daniel Golle wrote:

quoted

+  mediatek,usxgmii-performance-errata:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R
+      mode which needs a work-around in the driver. The work-around is
+      enabled using this flag.

Why do you need a property for this if you know that it is present on
the MT7988?

Because it is only present in one of the two SerDes channels.
Channel 0 needs the work-around, Channel 1 doesn't.

See also this commit in the vendor driver for reference[1].

We previously discussed that[2] and it was decided that a property
would be the prefered way to represent this as there aren't any other
per-instance differences which would justify another compatible.

Please put it in the commit message so that when the next version shows
up, Krzysztof doesn't show up and question the property for the third
time.

Also, on another note, this series is aimed at net-next but half the
series is fixed for incorrect bindings. Why not net?