Re: [PATCH v2 31/35] net: smc: use find_and_set_bit() in smc_wr_tx_get_free_slot_index()
From: Yury Norov <yury.norov@gmail.com>
Date: 2023-12-11 22:34:38
Also in:
linux-s390, lkml
From: Yury Norov <yury.norov@gmail.com>
Date: 2023-12-11 22:34:38
Also in:
linux-s390, lkml
On Mon, Dec 04, 2023 at 10:40:20AM +0100, Alexandra Winter wrote:
On 03.12.23 20:33, Yury Norov wrote:quoted
The function opencodes find_and_set_bit() with a for_each() loop. Use it, and make the whole function a simple almost one-liner. While here, drop explicit initialization of *idx, because it's already initialized by the caller in case of ENOLINK, or set properly with ->wr_tx_mask, if nothing is found, in case of EBUSY. CC: Tony Lu <tonylu@linux.alibaba.com> CC: Alexandra Winter <wintera@linux.ibm.com> Signed-off-by: Yury Norov <yury.norov@gmail.com> ---Reviewed-by: Alexandra Winter <wintera@linux.ibm.com> Thanks a lot for the great helper function! I guess the top-level maintainers will figure out, how this series best finds its way upstream.
Thanks, Alexandra. :) People in this thread say just pick their subsystem patch together with #1. So, I'm going to send v3 with some minor tweaks, and if everything is OK, will pull all this in my bitmap-for-next branch. Thanks, Yury