Re: [PATCH v3 net-next] packet: add a generic drop reason for receive

From
Eric Dumazet <hidden>
Date
2023-12-02 10:41:03
Also in
lkml
Reply to
Yan Zhai, 2023-12-01
On Fri, Dec 1, 2023 at 7:32 PM Yan Zhai [off-list ref] wrote:
Commit da37845fdce2 ("packet: uses kfree_skb() for errors.") switches
from consume_skb to kfree_skb to improve error handling. However, this
could bring a lot of noises when we monitor real packet drops in
kfree_skb[1], because in tpacket_rcv or packet_rcv only packet clones
can be freed, not actual packets.

Adding a generic drop reason to allow distinguish these "clone drops".

[1]: https://lore.kernel.org/netdev/CABWYdi00L+O30Q=Zah28QwZ_5RU-xcxLFUK2Zj08A8MrLk9jzg@mail.gmail.com/ (local)
Fixes: da37845fdce2 ("packet: uses kfree_skb() for errors.")
Suggested-by: Eric Dumazet <redacted>
Signed-off-by: Yan Zhai <redacted>
---
Reviewed-by: Eric Dumazet <redacted>
Thread (4 messages) 4 messages, 3 authors, last reply 2023-12-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help