Mon, Dec 11, 2023 at 01:20:13PM CET, swarupkotikalapudi@gmail.com wrote:

esOn Mon, Dec 11, 2023 at 10:46:18AM +0100, Jiri Pirko wrote:

quoted

Fri, Dec 08, 2023 at 07:25:15PM CET, swarupkotikalapudi@gmail.com wrote:

quoted

Add some missing(not all) attributes in devlink.yaml.

Signed-off-by: Swarup Laxman Kotiaklapudi <redacted>
Suggested-by: Jiri Pirko <jiri@resnulli.us>
---
V6:
 - Fix review comments

Would be nice to list what changes you actually did.

Nevertheless, patch looks fine to me.

Reviewed-by: Jiri Pirko <redacted>

Hi Jiri,

Do you mean in the commit message, i should have listed all the changes?

In the changelog (the line I commented), you should try to describe what
exactly did you change from the last version, so the reviewer knows what
to focus on and what to expect.

Please clarify, if required i update the commit message.

No, next time.

Thanks,
Swarup