Wed, Dec 06, 2023 at 04:19:44AM CET, kuba@kernel.org wrote:

On Sat,  2 Dec 2023 18:00:48 +0530 Swarup Laxman Kotiaklapudi wrote:

quoted

Add some missing(not all) attributes in devlink.yaml.

Hi Jiri,

Do you want to take a closer look at the spec here?
Looks fine to me, on a quick scroll.

Yep, will do that later today.

quoted

Suggested-by: Jiri Pirko <jiri@resnulli.us>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Fixes: f2f9dd164db0 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")

I'll drop these when / if applying, FWIW. 

Swarup, for future reference if there are comments / changes suggested
during normal review process you don't have to add the Suggested-by

My "suggested-by" is probably fine as I suggested Swarup to make the patch :)

tag. The expectation is that the reviewer will send a Reviewed-by tag
themselves at the end instead.