Thread (30 messages) 30 messages, 3 authors, 2023-12-11

Re: [PATCH v7 net-next 2/8] net: ethernet: am65-cpsw: cleanup TAPRIO handling

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2023-12-04 13:38:30

On Fri, Dec 01, 2023 at 03:57:56PM +0200, Roger Quadros wrote:
Handle offloading commands using switch-case in
am65_cpsw_setup_taprio().

Move checks to am65_cpsw_taprio_replace().

Use NL_SET_ERR_MSG_MOD for error messages.
Change error message from "Failed to set cycle time extension"
to "cycle time extension not supported"

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
After this change (I guess), it's pointless to initialize

	int ret = 0, tact = TACT_PROG;

when both will be overwritten later in am65_cpsw_taprio_replace(), and
nothing depends upon their initial values.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help