Re: [PATCH bpf] netkit: Reject IFLA_NETKIT_PEER_INFO in netkit_change_link
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-11-27 18:22:25
Also in:
bpf
On Mon, 27 Nov 2023 14:43:11 +0100 Daniel Borkmann wrote:
+ if (data[IFLA_NETKIT_PEER_INFO]) {
+ NL_SET_ERR_MSG_ATTR(extack, data[IFLA_NETKIT_PEER_INFO],
+ "netkit peer info cannot be changed after device creation");
+ return -EACCES;
+ }Why EACCES? It doesn't have much to do with permissions and all netlink validation errors use EINVAL. IMO this is a basic case of "attribute not defined in the policy", NLA_REJECT, so EINVAL..