Re: [PATCH net-next v8 08/15] p4tc: add P4 data types

From
Jamal Hadi Salim <jhs@mojatatu.com>
Date
2023-11-17 12:01:44
Also in
bpf
Reply to
Jiri Pirko, 2023-11-16
On Thu, Nov 16, 2023 at 11:03 AM Jiri Pirko [off-list ref] wrote:
Thu, Nov 16, 2023 at 03:59:41PM CET, jhs@mojatatu.com wrote:

[...]
quoted
diff --git a/include/net/p4tc_types.h b/include/net/p4tc_types.h
new file mode 100644
index 000000000..8f6f002ae
[...]
quoted
+#define P4T_MAX_BITSZ 128
[...]
quoted
+#define P4T_MAX_STR_SZ 32
[...]

quoted
diff --git a/include/uapi/linux/p4tc.h b/include/uapi/linux/p4tc.h
new file mode 100644
index 000000000..ba32dba66
--- /dev/null
+++ b/include/uapi/linux/p4tc.h
@@ -0,0 +1,33 @@
+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+#ifndef __LINUX_P4TC_H
+#define __LINUX_P4TC_H
+
+#define P4TC_MAX_KEYSZ 512
+
+enum {
+      P4T_UNSPEC,
I wonder, what it the reason for "P4T"/"P4TC" prefix inconsistency.
In the kernel header, that could be fixes, but in uapi header this is
forever. Is this just to be aligned with other TC uapi
inconsitencies? :D
P4T is for "types" - but ok, we can change it to P4TC_XXX for consistency.

cheers,
jamal
Thread (79 messages) 79 messages, 9 authors, last reply 2023-11-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help