On Sun, Nov 26, 2023 at 09:11:28PM +0100, Linus Walleij wrote:

On Sun, Nov 26, 2023 at 5:45 PM Andrew Lunn [off-list ref] wrote:

quoted

On Sun, Nov 26, 2023 at 12:46:03AM +0100, Linus Walleij wrote:

quoted

On Thu, Nov 23, 2023 at 5:13 PM Andrew Lunn [off-list ref] wrote:

quoted

What i would really like to see happen is that the DSA core handles
the registration of the LEDs, similar to how phylib does. The DT
binding should be identical for all DSA devices, so there is no need
for each driver to do its own parsing.

There are some WIP patches at

https://github.com/lunn/linux.git leds-offload-support-reduced-auto-netdev

which implement this. Feel free to make use of them.

Oh it's quite a lot of patches, I really cannot drive that because there are
so many things about them that I don't understand the thinking behind...
But I like what I see!

O.K. Let me dust them off, rebase them on net-next and see what is
missing.

Thanks Andrew, appreciated!

I'll be happy to rebuild it on top of what you put as the baseline,
hopefully it will help Christian with the qca8k support as well?

Sure thing. I can test and see if I have problem with the generic
approach.

quoted

You have some fibre things i don't have. I don't have a
machine with fibre so i cannot test that.

I can test that, the way I check for its presence is through device tree looking
for an "sfp" phandle, AFAICT I don't see that the hardware can tell be
when there
is a fiber connected, but alas I don't have any datasheet.

Yours,
Linus Walleij

-- 
	Ansuel