Thread (27 messages) 27 messages, 4 authors, 2023-11-24

Re: [PATCH v5 3/6] net: phy: at803x: add QCA8084 ethernet phy support

flat view

From: Jie Luo <hidden>
Date: 2023-11-20 08:56:07
Also in: linux-devicetree, linux-doc, lkml


On 11/19/2023 8:23 AM, Jakub Kicinski wrote:
On Sat, 18 Nov 2023 14:27:51 +0800 Luo Jie wrote:
quoted
+		/* There are two PCSs available for QCA8084, which support the following
+		 * interface modes.
+		 *
+		 * 1. PHY_INTERFACE_MODE_10G_QXGMII utilizes PCS1 for all available 4 ports,
+		 * which is for all link speeds.
+		 *
+		 * 2. PHY_INTERFACE_MODE_2500BASEX utilizes PCS0 for the fourth port,
+		 * which is only for the link speed 2500M same as QCA8081.
+		 *
+		 * 3. PHY_INTERFACE_MODE_SGMII utilizes PCS0 for the fourth port,
+		 * which is for the link speed 10M, 100M and 1000M same as QCA8081.
Wrap the comments please.

Please use checkpatch with --max-line-length=80
Thanks Jakub, i will add this option for the patch check.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help