Re: [PATCH v2 net 4/7] net/sched: taprio: get corrected value of cycle_time and interval
From: kernel test robot <hidden>
Date: 2023-11-10 19:22:57
Also in:
lkml, llvm, oe-kbuild-all
Hi Faizal, kernel test robot noticed the following build warnings: [auto build test WARNING on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Faizal-Rahim/net-sched-taprio-fix-too-early-schedules-switching/20231107-192843 base: net/main patch link: https://lore.kernel.org/r/20231107112023.676016-5-faizal.abdul.rahim%40linux.intel.com patch subject: [PATCH v2 net 4/7] net/sched: taprio: get corrected value of cycle_time and interval config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20231111/202311110208.GT4trtEk-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231111/202311110208.GT4trtEk-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202311110208.GT4trtEk-lkp@intel.com/ (local) All warnings (new ones prefixed by >>):
quoted
net/sched/sch_taprio.c:227:5: warning: no previous prototype for function 'get_interval' [-Wmissing-prototypes]
227 | u32 get_interval(const struct sched_entry *entry,
| ^
net/sched/sch_taprio.c:227:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
227 | u32 get_interval(const struct sched_entry *entry,
| ^
| static quoted
net/sched/sch_taprio.c:236:5: warning: no previous prototype for function 'get_cycle_time' [-Wmissing-prototypes]
236 | s64 get_cycle_time(const struct sched_gate_list *oper)
| ^
net/sched/sch_taprio.c:236:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
236 | s64 get_cycle_time(const struct sched_gate_list *oper)
| ^
| static
2 warnings generated.
vim +/get_interval +227 net/sched/sch_taprio.c
226
> 227 u32 get_interval(const struct sched_entry *entry,
228 const struct sched_gate_list *oper)
229 {
230 if (entry->correction_active)
231 return entry->interval + oper->cycle_time_correction;
232 else
233 return entry->interval;
234 }
235
> 236 s64 get_cycle_time(const struct sched_gate_list *oper)
237 {
238 if (cycle_corr_active(oper->cycle_time_correction))
239 return oper->cycle_time + oper->cycle_time_correction;
240 else
241 return oper->cycle_time;
242 }
243
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki