Re: [PATCH net-next v3] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml
From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-11-23 10:12:18
Also in:
linux-kernel-mentees
From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-11-23 10:12:18
Also in:
linux-kernel-mentees
Thu, Nov 23, 2023 at 11:01:19AM CET, swarupkotikalapudi@gmail.com wrote:
Add some missing(not all) attributes in devlink.yaml.
Re-generate the related devlink-user.[ch] code.
enum have been given name as devlink_stats(for trap stats)
and devlink_trap_metadata_type(for trap metadata type)
Test result with trap-get command:
$ sudo ./tools/net/ynl/cli.py \
--spec Documentation/netlink/specs/devlink.yaml \
--do trap-get --json '{"bus-name": "netdevsim", \
"dev-name": "netdevsim1", \
"trap-name": "ttl_value_is_too_small"}' --process-unknown
{'attr-stats': {'rx-bytes': 47918326, 'rx-dropped': 21,
'rx-packets': 337453},
'bus-name': 'netdevsim',
'dev-name': 'netdevsim1',
'trap-action': 'trap',
'trap-generic': True,
'trap-group-name': 'l3_exceptions',
'trap-metadata': {'metadata-type-in-port': True},
'trap-name': 'ttl_value_is_too_small',
'trap-type': 'exception'}1. You have to maintain 24 hours between submission of one patch/patchset: https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html 2. You didn't address my comment to last version