Fri, Oct 27, 2023 at 11:11:19AM CEST, aaptel@nvidia.com wrote:

[..]

quoted

quoted

+      notify = !!ret;
+      ret = prepare_data(data, ULP_DDP_CMD_SET);

Why you send it back for set? (leaving notify aside)

We send back the final caps so userspace can see and compare what was
requested vs the result of what the driver could enable.
This is following the convention of ethtool features.

Okay.

[..]