Re: [PATCH 11/18] nvme-fabrics: parse options 'keyring' and 'tls_key'

On Thu, Aug 24, 2023 at 04:39:18PM +0200, Hannes Reinecke wrote:

 	args.ta_data = queue;
 	args.ta_my_peerids[0] = pskid;
 	args.ta_num_peerids = 1;
+	if (nctrl->opts->keyring)
+		keyring = key_serial(nctrl->opts->keyring;

The key_serial call is missing the closing ')'. I fixed it up while
applying, but a little concerning. I'm guessing you tested with a
previous version?

Anyway, I've applied the series to nvme-6.7 since this otherwise looks
good. I'll let it sit there a day and send a pull request to Jens if the
build bots don't complain.