Thread (19 messages) 19 messages, 8 authors, 2023-10-26

Re: [PATCH 0/3] ethtool: Add ethtool_puts()

From: Joe Perches <joe@perches.com>
Date: 2023-10-26 17:57:59
Also in: intel-wired-lan, linux-hyperv, lkml

On Thu, 2023-10-26 at 10:49 -0700, Kees Cook wrote:
On Thu, Oct 26, 2023 at 09:33:17AM -0700, Joe Perches wrote:
quoted
On Thu, 2023-10-26 at 08:47 -0700, Kees Cook wrote:
quoted
On Wed, Oct 25, 2023 at 11:40:31PM +0000, Justin Stitt wrote:
quoted
@replace_2_args@
identifier BUF;
expression VAR;
@@

-       ethtool_sprintf
+       ethtool_puts
        (&BUF, VAR)
I think cocci will do a better job at line folding if we adjust this
rule like I had to adjust the next rule: completely remove and re-add
the arguments:

-       ethtool_sprintf(&BUF, VAR)
+       ethtool_puts(&BUF, VAR)

Then I think the handful of weird line wraps in the treewide patch will
go away.
Perhaps this, but i believe spatch needs
	 --max-width=80
to fill all 80 columns
Ah, yeah. Default is 78. Current coding style max is 100... I'll adjust
my local wrappers.
Coding style max is still 80 with exceptions allowed to 100
not a generic use of 100.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help