Re: [PATCH net-next v4 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports
From: Krzysztof Kozlowski <hidden>
Date: 2023-10-20 11:10:52
Also in:
linux-arm-kernel, linux-devicetree, lkml
On 18/10/2023 13:11, Linus Walleij wrote:
On Wed, Oct 18, 2023 at 12:32 PM Rob Herring [off-list ref] wrote:quoted
On Wed, 18 Oct 2023 11:03:40 +0200, Linus Walleij wrote:quoted
quoted
Bindings using dsa.yaml#/$defs/ethernet-ports specify that a DSA switch node need to have a ports or ethernet-ports subnode, and that is actually required, so add requirements using oneOf. Suggested-by: Rob Herring <robh@kernel.org> Signed-off-by: Linus Walleij <redacted> --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++ 1 file changed, 6 insertions(+)My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:7: [warning] wrong indentation: expected 8 but found 6 (indentation) ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:7: [warning] wrong indentation: expected 8 but found 6 (indentation)Really? + oneOf: + - required: + - ports
.........^ here
+ - required: + - ethernet-ports Two spaces after the oneOf, 2 spaces after a required as usual. I don't get it.
Although YAML accepts your indentation, yamllint does not and we always, always, expected yamllint flavor of syntax. Best regards, Krzysztof