Re: [PATCH v2 04/13] linkmode: convert linkmode_{test,set,clear,mod}_bit() to macros

From
Jakub Kicinski <kuba@kernel.org>
Date
2023-10-19 00:28:01
Also in
dm-devel, linux-btrfs, linux-s390, lkml, ntfs3
Reply to
Alexander Lobakin, 2023-10-16
On Mon, 16 Oct 2023 18:52:38 +0200 Alexander Lobakin wrote:
Since commit b03fc1173c0c ("bitops: let optimize out non-atomic bitops
on compile-time constants"), the non-atomic bitops are macros which can
be expanded by the compilers into compile-time expressions, which will
result in better optimized object code. Unfortunately, turned out that
passing `volatile` to those macros discards any possibility of
optimization, as the compilers then don't even try to look whether
the passed bitmap is known at compilation time. In addition to that,
the mentioned linkmode helpers are marked with `inline`, not
`__always_inline`, meaning that it's not guaranteed some compiler won't
uninline them for no reason, which will also effectively prevent them
from being optimized (it's a well-known thing the compilers sometimes
uninline `2 + 2`).
Convert linkmode_*_bit() from inlines to macros. Their calling
convention are 1:1 with the corresponding bitops, so that it's not even
needed to enumerate and map the arguments, only the names. No changes in
vmlinux' object code (compiled by LLVM for x86_64) whatsoever, but that
doesn't necessarily means the change is meaningless.
Acked-by: Jakub Kicinski <kuba@kernel.org>

This one can go in with the rest, it's trivial enough.
Thread (22 messages) 22 messages, 4 authors, last reply 2023-11-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help