On 10/11/23 19:10, Eric Dumazet wrote:

On Tue, Oct 10, 2023 at 1:07 AM Dmitry Safonov [off-list ref] wrote:

[..]

quoted

 static inline struct tcp_timewait_sock *tcp_twsk(const struct sock *sk)

diff --git a/include/net/tcp_ao.h b/include/net/tcp_ao.h
index 629ab0365b83..af2caf7e76fc 100644
--- a/include/net/tcp_ao.h
+++ b/include/net/tcp_ao.h

@@ -85,6 +85,7 @@ struct tcp_ao_info {
                                __unused        :31;
        __be32                  lisn;
        __be32                  risn;
+       atomic_t                refcnt;         /* Protects twsk destruction */

This needs to be a refcount_t

Sure, sounds good.

Thanks,
           Dmitry