RE: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, October 5, 2023 2:11 AM
To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
conor+dt@kernel.org; Simek, Michal [off-list ref];
linux@armlinux.org.uk; f.fainelli@gmail.com; netdev@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; git (AMD-Xilinx) [off-list ref]; Sarath Babu
Naidu Gaddam [off-list ref]
Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for
dmaengine support

On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote:

quoted

  */
-static int axienet_open(struct net_device *ndev)
+

nit: spurious new line

quoted

+static inline int axienet_init_legacy_dma(struct net_device *ndev)

nit: no need for the inline, it has one caller and isn't on the fast path

Thanks, will fix both in next version.