Thread (17 messages) 17 messages, 7 authors, 2023-10-10

Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

From: Phillip Potter <phil@philpotter.co.uk>
Date: 2023-10-02 21:45:41
Also in: dri-devel, intel-gfx, linux-hyperv, linux-raid, linux-rdma, linux-scsi, linux-serial, linuxppc-dev, lkml, xen-devel

quoted hunk ↗ jump to hunk
From: Joel Granados <redacted>

This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/ (local))

Remove sentinel element from cdrom_table

Signed-off-by: Joel Granados <redacted>
---
 drivers/cdrom/cdrom.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index cc2839805983..a5e07270e0d4 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -3655,7 +3655,6 @@ static struct ctl_table cdrom_table[] = {
 		.mode		= 0644,
 		.proc_handler	= cdrom_sysctl_handler
 	},
-	{ }
 };
 static struct ctl_table_header *cdrom_sysctl_header;

-- 
2.30.2

Hi Joel,

Looks good to me, many thanks. I'll send on for inclusion.

Reviewed-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help