On Sat, Sep 30, 2023 at 05:52:17PM +0100, Phillip Potter wrote:

On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote:

quoted

On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote:

quoted

On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote:

quoted

From: Joel Granados <redacted>

This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/ (local))

Remove sentinel element from cdrom_table

Signed-off-by: Joel Granados <redacted>
---
 drivers/cdrom/cdrom.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index cc2839805983..451907ade389 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c

@@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = {
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
 		.proc_handler	= cdrom_sysctl_handler
-	},
-	{ }
+	}

You should have the final entry as "}," so as to make any future
additions to the list to only contain that entry, that's long been the
kernel style for lists like this.

Will send a V2 with this included. Thx.

quoted

So your patches will just remove one line, not 2 and add 1, making it a
smaller diff.

indeed.

quoted

thanks,

greg k-h

-- 

Joel Granados

Hi Joel,

Thank you for your patch. I look forward to seeing V2, and will be happy
to review it.

Am following a reported oops. Once I straighten that out, I'll send out
a V2

Bet

Regards,
Phil

-- 

Joel Granados