[RFC PATCH 1/3] ss: prevent "Process" column from being printed unless requested
From: Quentin Deslandes <hidden>
Date: 2023-10-27 12:24:24
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Quentin Deslandes <hidden>
Date: 2023-10-27 12:24:24
Subsystem:
the rest · Maintainer:
Linus Torvalds
Commit 5883c6eba517 ("ss: show header for --processes/-p") added
"Process" to the list of columns printed by ss. However, the "Process"
header is now printed even if --processes/-p is not used.
This change aims to fix this by moving the COL_PROC column ID to the same
index as the corresponding column structure in the columns array, and
enabling it if --processes/-p is used.
Signed-off-by: Quentin Deslandes <redacted>
---
misc/ss.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index 7e67dbe4..e35a16e5 100644
--- a/misc/ss.c
+++ b/misc/ss.c@@ -100,8 +100,8 @@ enum col_id { COL_SERV, COL_RADDR, COL_RSERV, - COL_EXT, COL_PROC, + COL_EXT, COL_MAX };
@@ -5786,6 +5786,9 @@ int main(int argc, char *argv[]) if (ssfilter_parse(¤t_filter.f, argc, argv, filter_fp)) usage(); + if (!show_processes) + columns[COL_PROC].disabled = 1; + if (!(current_filter.dbs & (current_filter.dbs - 1))) columns[COL_NETID].disabled = 1;
--
2.41.0