Re: [PATCH net] llc: verify mac len before reading mac header

On Wed, Oct 25, 2023 at 7:01 PM Jakub Kicinski [off-list ref] wrote:

On Tue, 24 Oct 2023 15:49:36 -0400 Willem de Bruijn wrote:

quoted

@@ -153,6 +153,9 @@ int llc_sap_action_send_test_r(struct llc_sap *sap, struct sk_buff *skb)
      int rc = 1;
      u32 data_size;

+     if (skb->mac_len < ETH_HLEN)
+             return 0;

I think this one may want 1 to indicate error, technically. No?

Absolutely, thanks. For both tests.

Will send a v2, with that Fixes tag too.