Re: [PATCH net-next v6 3/5] rust: add second `bindgen` pass for enum exhaustiveness checking
From: Benno Lossin <hidden>
Date: 2023-10-24 16:29:29
Also in:
rust-for-linux
From: Benno Lossin <hidden>
Date: 2023-10-24 16:29:29
Also in:
rust-for-linux
On 24.10.23 02:58, FUJITA Tomonori wrote:
From: Miguel Ojeda <ojeda@kernel.org>
I think this commit message should also explain what it is doing and not only the error below. -- Cheers, Benno
error[E0005]: refutable pattern in function argument
--> rust/bindings/bindings_enum_check.rs:29:6
|
29 | (phy_state::PHY_DOWN
| ______^
30 | | | phy_state::PHY_READY
31 | | | phy_state::PHY_HALTED
32 | | | phy_state::PHY_ERROR
... |
35 | | | phy_state::PHY_NOLINK
36 | | | phy_state::PHY_CABLETEST): phy_state,
| |______________________________^ pattern `phy_state::PHY_NEW` not covered
|
note: `phy_state` defined here
--> rust/bindings/bindings_generated_enum_check.rs:60739:10
|
60739 | pub enum phy_state {
| ^^^^^^^^^
...
60745 | PHY_NEW = 5,
| ------- not covered
= note: the matched value is of type `phy_state`
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---[...]