Re: [patch net-next v3 0/7] devlink: fix a deadlock when taking devlink instance lock while holding RTNL lock

From
patchwork-bot+netdevbpf@kernel.org
Date
2023-10-18 08:30:25
Reply to
Jiri Pirko, 2023-10-13
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller [off-list ref]:

On Fri, 13 Oct 2023 14:10:22 +0200 you wrote:
From: Jiri Pirko <redacted>

devlink_port_fill() may be called sometimes with RTNL lock held.
When putting the nested port function devlink instance attrs,
current code takes nested devlink instance lock. In that case lock
ordering is wrong.

[...]
Here is the summary with links:
  - [net-next,v3,1/7] net: treat possible_net_t net pointer as an RCU one and add read_pnet_rcu()
    https://git.kernel.org/netdev/net-next/c/2034d90ae41a
  - [net-next,v3,2/7] devlink: call peernet2id_alloc() with net pointer under RCU read lock
    https://git.kernel.org/netdev/net-next/c/c503bc7df602
  - [net-next,v3,3/7] devlink: take device reference for devlink object
    https://git.kernel.org/netdev/net-next/c/a380687200e0
  - [net-next,v3,4/7] devlink: don't take instance lock for nested handle put
    https://git.kernel.org/netdev/net-next/c/b5f4e371336a
  - [net-next,v3,5/7] Documentation: devlink: add nested instance section
    https://git.kernel.org/netdev/net-next/c/b6f23b319aad
  - [net-next,v3,6/7] Documentation: devlink: add a note about RTNL lock into locking section
    https://git.kernel.org/netdev/net-next/c/bb11cf9b2c4a
  - [net-next,v3,7/7] devlink: document devlink_rel_nested_in_notify() function
    https://git.kernel.org/netdev/net-next/c/5d77371e8c85

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Thread (16 messages) 16 messages, 3 authors, last reply 2023-10-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help