On 10/12/2023 4:40 PM, Jakub Kicinski wrote:

On Wed, 11 Oct 2023 17:40:04 -0700 Paul M Stillwell Jr wrote:

quoted

OK, so what if we changed the code to create a new debugfs file entry
for each module and used the dentry for ther file to know what file is
being written to. Then we would only need to parse the log level. Would
that be acceptable?

Yes, even better!

Cool, I'll work on this along with the other changes we discussed.

quoted

My confusion is around what makes the cmdline parsing harder to follow.
Obviously for me it's easy :) so I am trying to understand your point of
view.

Dunno how to explain it other than "took me more than 10min to
understand this code and I only had 10min" :)  Reviewers have
their own angle when evaluation code which doesn't always align
with the author's..

No problem, I appreciate your feedback. Hopefully the new patches are 
easier to follow. I'll also try to keep your 10 minute rule in mind :)