Re: [PATCH net 5/5] net/smc: put sk reference if close work was canceled
From: Wenjia Zhang <wenjia@linux.ibm.com>
Date: 2023-10-12 19:04:25
Also in:
linux-rdma, linux-s390
On 11.10.23 09:33, D. Wythe wrote:
From: "D. Wythe" <alibuda@linux.alibaba.com> Note that we always hold a reference to sock when attempting to submit close_work.
yes Therefore, if we have successfully
canceled close_work from pending, we MUST release that reference to avoid potential leaks.
Isn't the corresponding reference already released inside the smc_close_passive_work()?
quoted hunk ↗ jump to hunk
Fixes: 42bfba9eaa33 ("net/smc: immediate termination for SMCD link groups") Signed-off-by: D. Wythe <alibuda@linux.alibaba.com> --- net/smc/smc_close.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/net/smc/smc_close.c b/net/smc/smc_close.c index 449ef45..10219f5 100644 --- a/net/smc/smc_close.c +++ b/net/smc/smc_close.c@@ -116,7 +116,8 @@ static void smc_close_cancel_work(struct smc_sock *smc) struct sock *sk = &smc->sk; release_sock(sk); - cancel_work_sync(&smc->conn.close_work); + if (cancel_work_sync(&smc->conn.close_work)) + sock_put(sk); cancel_delayed_work_sync(&smc->conn.tx_work); lock_sock(sk); }