Thread (10 messages) 10 messages, 3 authors, 2023-10-03

Re: [PATCH nf] netfilter: handle the connecting collision properly in nf_conntrack_proto_sctp

From: Florian Westphal <fw@strlen.de>
Date: 2023-10-03 14:23:50
Also in: linux-sctp, netfilter-devel

Xin Long [off-list ref] wrote:
quoted
The type of vtag is u32. But the type of ct->proto.sctp.vtag[!dir] and init_tag
is __be32. This doesn't seem right (and makes Sparse unhappy).
You're right, I will fix it and re-post with tag:

Fixes: 9fb9cbb1082d ("[NETFILTER]: Add nf_conntrack subsystem.")
I'm fine with this, the bug is likely inherited from
ipt_conntrack_sctp.c, but that doesn't exist anymore.

Would you also fix up the __be32/u32 confusion?

Better to not add more sparse warnings...

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help