Re: [PATCH net, 1/3] net: mana: Fix TX CQE error handling
From: Simon Horman <horms@kernel.org>
Date: 2023-09-29 05:50:48
Also in:
bpf, linux-hyperv, linux-rdma, lkml, stable
On Fri, Sep 29, 2023 at 07:47:57AM +0200, Simon Horman wrote:
On Sat, Sep 23, 2023 at 06:31:45PM -0700, Haiyang Zhang wrote:quoted
For an unknown TX CQE error type (probably from a newer hardware), still free the SKB, update the queue tail, etc., otherwise the accounting will be wrong. Also, TX errors can be triggered by injecting corrupted packets, so replace the WARN_ONCE to ratelimited error logging, because we don't need stack trace here. Cc: stable@vger.kernel.org Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>Reviewed-by: Simon Horman <horms@kernel.org>
Sorry, one latent question. The patch replaces WARN_ONCE with a net_ratelimit()'d netdev_err(). But I do wonder if, as a fix, netdev_err_once() would be more appropriate.