On Thu, Sep 21, 2023 at 03:10:26PM -0700, Song Liu wrote:

On Mon, Sep 18, 2023 at 12:30 AM Mike Rapoport [off-list ref] wrote:

quoted

[...]

quoted

+
+#include <linux/mm.h>
+#include <linux/vmalloc.h>
+#include <linux/execmem.h>
+#include <linux/moduleloader.h>
+
+static void *execmem_alloc(size_t size)
+{
+       return module_alloc(size);
+}
+
+void *execmem_text_alloc(enum execmem_type type, size_t size)
+{
+       return execmem_alloc(size);
+}

execmem_text_alloc (and later execmem_data_alloc) both take "type" as
input. I guess we can just use execmem_alloc(type, size) for everything?

We could but I still prefer to keep this distinction.
 

Thanks,
Song

quoted

+
+void execmem_free(void *ptr)
+{
+       /*
+        * This memory may be RO, and freeing RO memory in an interrupt is not
+        * supported by vmalloc.
+        */
+       WARN_ON(in_interrupt());
+       vfree(ptr);
+}
--
2.39.2

-- 
Sincerely yours,
Mike.