Re: [RFC net-next v3 4/6] net: phy: nxp-c45-tja11xx: add MACsec support

On 07.09.2023 18:00, Simon Horman wrote:

On Wed, Sep 06, 2023 at 07:01:32PM +0300, Radu Pirea (NXP OSS) wrote:

quoted

+		sa = nxp_c45_find_sa(&pos->sa_list, TX_SA, encoding_sa);
+		if (!IS_ERR(sa))
+			macsec_pn_wrapped(pos->secy, sa->sa);
+		else
+			WARN_ON(!sa);

Hi Radu,

Smatch doesn't seem to think that sa can be NULL: it is either a valid
pointer or an error pointer.

Thank you.
I was not able to reproduce the issue using smatch 1.73. With the master version worked.

-- 
Radu P.