Thread (35 messages) 35 messages, 6 authors, 2023-10-03

Re: [RFC PATCH net-next 6/7] net: ethtool: add a netlink command to get PHY information

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2023-09-07 15:33:15
Also in: lkml

Hello Russell,

On Thu, 7 Sep 2023 11:04:56 +0100
"Russell King (Oracle)" [off-list ref] wrote:
On Thu, Sep 07, 2023 at 11:24:04AM +0200, Maxime Chevallier wrote:
quoted
+	data->phyindex = req_info->phyindex;
+	data->drvname = phydev->drv->name;
+	if (phydev->is_on_sfp_module)  
Please use the accessor provided:

	if (phy_on_sfp(phydev))
Ack, I'll switch to that then.

Thanks,

Maxime

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help