Re: [PATCH v10 net-next 09/23] net/tcp: Add TCP-AO sign to twsk

On 8/16/23 13:03, Simon Horman wrote:

On Tue, Aug 15, 2023 at 08:14:38PM +0100, Dmitry Safonov wrote:

...

quoted

@@ -1183,6 +1216,7 @@ static void tcp_v6_reqsk_send_ack(const struct sock *sk, struct sk_buff *skb,
 			ipv6_get_dsfield(ipv6_hdr(skb)), 0,
 			READ_ONCE(sk->sk_priority),
 			READ_ONCE(tcp_rsk(req)->txhash));
+			NULL, NULL, 0, 0);

Hi Dmitry,

This seems to add a syntax error.

...

Rectified by "net/tcp: Wire TCP-AO to request sockets".

Likely, an artifact from the rebase over READ_ONCE() for txhash.

I will correct it in v11, thanks for noticing!

-- 
          Dmitry