Thread (3 messages) 3 messages, 3 authors, 2023-09-01

Re: [PATCH] can: etas_es58x: Add check for alloc_can_err_skb

flat view

From: Denis Kirjanov <hidden>
Date: 2023-09-01 11:12:31
Also in: linux-can, lkml


On 9/1/23 11:27, Jiasheng Jiang wrote:
quoted hunk ↗ jump to hunk
Add check for the return value of alloc_can_err_skb in order to
avoid NULL pointer dereference.

Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/net/can/usb/etas_es58x/es58x_core.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
index 0c7f7505632c..d694cb22d9f4 100644
--- a/drivers/net/can/usb/etas_es58x/es58x_core.c
+++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
@@ -680,6 +680,8 @@ int es58x_rx_err_msg(struct net_device *netdev, enum es58x_err error,
 	}
 
 	skb = alloc_can_err_skb(netdev, &cf);
+	if (!skb)
+		return -ENOMEM;
Should you adjust the stats for dropped packets as well?
 
 	switch (error) {
 	case ES58X_ERR_OK:	/* 0: No error */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help