[PATCH] can: etas_es58x: Add check for alloc_can_err_skb

Subsystems: can network drivers, etas es58x can/usb driver, the rest

STALE1136d

3 messages, 3 authors, 2023-09-01 · open the first message on its own page

[PATCH] can: etas_es58x: Add check for alloc_can_err_skb

From: Jiasheng Jiang <hidden>
Date: 2023-09-01 08:34:48

Add check for the return value of alloc_can_err_skb in order to
avoid NULL pointer dereference.

Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/net/can/usb/etas_es58x/es58x_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
index 0c7f7505632c..d694cb22d9f4 100644
--- a/drivers/net/can/usb/etas_es58x/es58x_core.c
+++ b/drivers/net/can/usb/etas_es58x/es58x_core.c

@@ -680,6 +680,8 @@ int es58x_rx_err_msg(struct net_device *netdev, enum es58x_err error,
 	}
 
 	skb = alloc_can_err_skb(netdev, &cf);
+	if (!skb)
+		return -ENOMEM;
 
 	switch (error) {
 	case ES58X_ERR_OK:	/* 0: No error */

-- 
2.25.1

Re: [PATCH] can: etas_es58x: Add check for alloc_can_err_skb

From: Vincent MAILHOL <hidden>
Date: 2023-09-01 10:53:37

On Fri. 1 Sept 2023 at 19:22, Jiasheng Jiang [off-list ref] wrote:

quoted hunk

Add check for the return value of alloc_can_err_skb in order to
avoid NULL pointer dereference.

Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/net/can/usb/etas_es58x/es58x_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
index 0c7f7505632c..d694cb22d9f4 100644
--- a/drivers/net/can/usb/etas_es58x/es58x_core.c
+++ b/drivers/net/can/usb/etas_es58x/es58x_core.c

@@ -680,6 +680,8 @@ int es58x_rx_err_msg(struct net_device *netdev, enum es58x_err error,
        }

        skb = alloc_can_err_skb(netdev, &cf);
+       if (!skb)
+               return -ENOMEM;

NAK.

The checks on skb or cf are skipped intentionally here in order to
continue the error handling.

Later in this function, all the access to skb or cf and guarded by an:

        if (cf)

And if cf is not NULL, skb is also guaranteed not to be NULL. For
further details, please refer to this commit:

  https://git.kernel.org/torvalds/c/c8129487441e


Yours sincerely,
Vincent Mailhol

        switch (error) {
        case ES58X_ERR_OK:      /* 0: No error */
--
2.25.1

Re: [PATCH] can: etas_es58x: Add check for alloc_can_err_skb

From: Denis Kirjanov <hidden>
Date: 2023-09-01 11:12:31


On 9/1/23 11:27, Jiasheng Jiang wrote:

quoted hunk

Add check for the return value of alloc_can_err_skb in order to
avoid NULL pointer dereference.

Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Signed-off-by: Jiasheng Jiang <redacted>
---
 drivers/net/can/usb/etas_es58x/es58x_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
index 0c7f7505632c..d694cb22d9f4 100644
--- a/drivers/net/can/usb/etas_es58x/es58x_core.c
+++ b/drivers/net/can/usb/etas_es58x/es58x_core.c

@@ -680,6 +680,8 @@ int es58x_rx_err_msg(struct net_device *netdev, enum es58x_err error,
 	}
 
 	skb = alloc_can_err_skb(netdev, &cf);
+	if (!skb)
+		return -ENOMEM;

Should you adjust the stats for dropped packets as well?

 
 	switch (error) {
 	case ES58X_ERR_OK:	/* 0: No error */

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help