Re: [PATCH net-next v3 2/3] ptp: support multiple timestamp event readers
From: Richard Cochran <richardcochran@gmail.com>
Date: 2023-09-30 22:10:57
On Thu, Sep 28, 2023 at 03:35:43PM +0200, Xabier Marquiegui wrote:
quoted hunk ↗ jump to hunk
@@ -19,7 +19,12 @@ */ static struct posix_clock *get_posix_clock(struct file *fp) { - struct posix_clock *clk = fp->private_data; + struct posix_clock_user *pcuser = fp->private_data; + struct posix_clock *clk; + + if (!pcuser) + return NULL;
You added a test for (fp->private_data != NULL) that wasn't there before. Was there an issue with the existing code? If so, please fix that as the first patch in your series. If not, please remove the pointless test from your change. Thanks, Richard